btc: fix MSVC C2668 HexStr ambiguity breaking btc Windows release lane - #718
Closed
frstrtr wants to merge 1 commit into
Closed
btc: fix MSVC C2668 HexStr ambiguity breaking btc Windows release lane#718frstrtr wants to merge 1 commit into
frstrtr wants to merge 1 commit into
Conversation
submit_block_hex passed a std::vector<unsigned char> straight to HexStr. MSVC deems the vector->Span conversion ambiguous across the three overloads (Span<const uint8_t|char|std::byte>) where GCC/Clang pick uint8_t, breaking the btc Windows release lane (release run 29467003679, node.hpp:131 C2668). Wrap in an explicit Span<const unsigned char>, the idiom already used by every other coin lane.
Owner
Author
|
Duplicate of #717 (same single-site C2668 HexStr disambiguation at src/impl/btc/coin/node.hpp:131). #717 is fully green incl. ASan with a documented full-sweep of remaining HexStr sites; keeping it as the survivor. Closing this to avoid a merge collision. Branch ci-steward/btc-msvc-hexstr preserved (not deleted). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. v0.2.1 release run 29467003679 —
btc package (Windows x86_64)failed withnode.hpp(131,40): error C2668: HexStr ambiguous call. All 24 other lanes and the SHA256SUMS/draft step passed.Cause.
submit_block_hexpassed astd::vector<unsigned char>directly toHexStr. There are three overloads (Span<const uint8_t|char|std::byte>); MSVC finds the vector->Span conversion ambiguous where GCC/Clang resolve touint8_t.Fix. Wrap in an explicit
Span<const unsigned char>(data, size)— the idiom already used by every other coin lane (dgb/dash/ltc/bch). One line, btc-only, no behavior change.Validate: btc Windows lane should now compile. Signed commit; no self-merge — integrator gate.